Skip to content

chore: missing TS peer deps#101

Closed
trim21 wants to merge 1 commit into
fastify:masterfrom
trim21:missing-peer
Closed

chore: missing TS peer deps#101
trim21 wants to merge 1 commit into
fastify:masterfrom
trim21:missing-peer

Conversation

@trim21

@trim21 trim21 commented May 8, 2023

Copy link
Copy Markdown
Contributor

Checklist

@climba03003

Copy link
Copy Markdown
Member

Thanks for the PR.

tsd use it's own version of typescript.
We have no command or code directly link to use typescript either.
So, closing.

@climba03003 climba03003 closed this May 8, 2023
@trim21

trim21 commented May 8, 2023

Copy link
Copy Markdown
Contributor Author

Thanks for the PR.

tsd use it's own version of typescript. We have no command or code directly link to use typescript either. So, closing.

ts-standard require eslint ts parser and have a peer deps of ts

warning " > ts-standard@12.0.2" has unmet peer dependency "typescript@*".
warning "ts-standard > eslint-config-standard-with-typescript@23.0.0" has unmet peer dependency "typescript@*".
warning "ts-standard > @typescript-eslint/eslint-plugin > tsutils@3.21.0" has unmet peer dependency "typescript@>=2.8.0 || >= 3.2.0-dev || >= 3.3.0-dev || >= 3.4.0-dev || >= 3.5.0-dev || >= 3.6.0-dev || >= 3.6.0-beta || >= 3.7.0-dev || >= 3.7.0-beta".

@trim21

trim21 commented May 8, 2023

Copy link
Copy Markdown
Contributor Author

it's not for tsd, it's for eslint

@climba03003

climba03003 commented May 8, 2023

Copy link
Copy Markdown
Member

Absolutely a disaster when choosing to use ts-standard.
I would against it when I see it earlier.

ts-standard is leak of active contribution or maintenance.
It's dependencies is not updated since 2022 Dec.
See standard/ts-standard#286

Using it's underlying dependency directly provide more up-to-update experience.
And most of the dependency already changed to automatic publish. For example, eslint-config-standard-with-typescript.
See mightyiam/eslint-config-love@971c680

Not really against adding typescript, but the use of ts-standard.

@climba03003 climba03003 reopened this May 8, 2023
@trim21

trim21 commented May 8, 2023

Copy link
Copy Markdown
Contributor Author

Yes, another option

  "devDependencies": {
    "@typescript-eslint/eslint-plugin": "^5.59.2",
    "@typescript-eslint/parser": "^5.0.0",
    "benchmark": "^2.1.4",
    "eslint": "^8.40.0",
    "eslint-config-standard-with-typescript": "^34.0.1",
    "eslint-plugin-import": "^2.27.5",
    "eslint-plugin-n": "^15.0.0",
    "eslint-plugin-promise": "^6.0.0",
    "tap": "^16.0.0",
    "tsd": "^0.28.0",
    "typescript": "^5.0.4"
  },

@Uzlopak

Uzlopak commented May 8, 2023

Copy link
Copy Markdown
Contributor

I for the same reasons dislike this PR.

@Uzlopak Uzlopak closed this May 8, 2023
@trim21 trim21 deleted the missing-peer branch May 8, 2023 10:12
@trim21 trim21 mentioned this pull request May 8, 2023
4 tasks
@github-actions

github-actions Bot commented May 1, 2026

Copy link
Copy Markdown
Contributor

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators May 1, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants